Add eol to e2e and fix certifier logic #2396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-cronin
force-pushed
the
feat/add-eol-to-e2e
branch
2 times, most recently
from
6a26e15 to
958be3f
Compare
|
This PR should be merged after #2391 |
|
e2e test working locally: 
|
robert-cronin
force-pushed
the
feat/add-eol-to-e2e
branch
3 times, most recently
from
0ed7faf to
ef928a8
Compare
robert-cronin
force-pushed
the
feat/add-eol-to-e2e
branch
from
49d5c82 to
72bb4f2
Compare
pxp928
reviewed
Jan 24, 2025
| notGUACTypePackagePredicates(), | ||
| packageversion.Not( | ||
| packageversion.HasMetadataWith( | ||
| hasmetadata.KeyEQ("endoflife"), |
There was a problem hiding this comment.
Hmm, does this work? Are we not missing the timestamp field here per
guac/pkg/assembler/backends/ent/backend/search.go
Lines 128 to 130 in 72bb4f2
There was a problem hiding this comment.
The timestamp field is available on the hasMetadata to check the values similar to the others.
There was a problem hiding this comment.
Good point. Initially, I was trying to prevent duplicate nodes by not querying timestamp because the timestamp was new every time. But it's now using the date of last support as the timestamp so there won't be any duplicates. I've just updated it to match the others.
robert-cronin
force-pushed
the
feat/add-eol-to-e2e
branch
2 times, most recently
from
bf4eeeb to
f826c12
Compare
Signed-off-by: robert-cronin <[email protected]>
Signed-off-by: robert-cronin <[email protected]>
robert-cronin
force-pushed
the
feat/add-eol-to-e2e
branch
from
f826c12 to
f13ce3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Fixes #2395
In addition to adding the e2e test query, this PR will also address some issues with the EOL certifier logic. For example, the parsing of purls now uses standard helper methods and the check for whether a node has EOL data is now more specific to mitigate false positives.
PR Checklist
-sflag togit commit.make generatehas been runmake generatehas been runmake generatehas been runcollectsubprotobuf has been changed,make protohas been run